tree: drop support for cosaDir
#125
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've moved away from Gangplank for now in favour of `podman remote`: coreos/coreos-assembler#2860
This was a good idea, but in practice the CoreOS pipeline implements a more sophisticated version of it which include list splitting. We could try to upstream that, but in the meantime, this is only used by one upstream CI right now (cosa's), so we'll just inline it there. The reason for this is that it uses `cosaCmd` and `cosaDir`, both things I'm trying to get rid of.
Projects are now expected to be built in a separate pod (likely provisioned with `buildPod`) instead of building code directly in the cosa pod.
Support for the cosa directory being different from the working
directory makes implementation details messier.
Drop support for it.
Callers can still have their cosa directories be different from the
Jenkins workspace by first wrapping calls to the cosa APIs here in a
call to `dir(cosaDir)`:
```
dir(cosaDir) {
cosaBuild(skipKola: true)
kola()
kolaTestIso(skipMetal4k: true)
}
```
The cosa directory currently needs to be a subdirectory of the workspace
(see coreos#124).
|
This requires migrating all users away from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the cosa directory being different from the working
directory makes implementation details messier.
Drop support for it.
Callers can still have their cosa directories be different from the
Jenkins workspace by first wrapping calls to the cosa APIs here in a
call to
dir(cosaDir):The cosa directory currently needs to be a subdirectory of the workspace
(see #124).