Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kolaTestIso: add miniso-install to UEFI scenarios #134

Closed
wants to merge 1 commit into from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 7, 2022

This is tested on BIOS already, but it's useful to test on UEFI too because it implicitly also verifies that we can change kargs in the UEFI grub.cfg.

This is tested on BIOS already, but it's useful to test on UEFI too
because it implicitly also verifies that we can change kargs in the UEFI
`grub.cfg`.
@dustymabe
Copy link
Member

This LGTM, but let's hold it until this week's releases are out.

One other thing here. With the new pipeline work/migration these tests are quickly becoming "global", which means they need to run on older RHCOS releases (even ones that didn't have miniso support). I think we're going to need to accelerate denylist support for testiso bits (even if it's a hacky short term solution).

@cgwalters
Copy link
Member

With the new pipeline work/migration these tests are quickly becoming "global", which means they need to run on older RHCOS releases

Short term, I think we can explicitly only target building oscontainers for older RHCOS releases and backfill disk images. That is way, way, way more important than disk images.

(This also of course goes into coreos/coreos-assembler#2685 which creates a clearer distinction between these two things)

@jlebon
Copy link
Member Author

jlebon commented Mar 31, 2023

This was fixed a better way via coreos/coreos-assembler#3298.

@jlebon jlebon closed this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants