gangplank: additions to aid in FCOS AARCH64 building #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
requested review from
darkmuggle,
jlebon,
mike-nguyen and
ravanelli
as code owners
dustymabe
force-pushed
the
dusty-gangplank-additions-pr
branch
from
8080351 to
d4e055c
Compare
darkmuggle
approved these changes
Jul 28, 2021
ravanelli
approved these changes
Jul 28, 2021
jlebon
reviewed
Jul 28, 2021
vars/gangplank.groovy
Outdated
Comment on lines
140
to
148
| withCredentials([ | ||
| string(credentialsId: 'fcos-aarch64-builder-host-string', | ||
| variable: 'REMOTEHOST'), | ||
| string(credentialsId: 'fcos-aarch64-builder-uid-string', | ||
| variable: 'REMOTEUID'), | ||
| sshUserPrivateKey(credentialsId: 'fcos-aarch64-builder-sshkey-key', | ||
| usernameVariable: 'REMOTEUSER', | ||
| keyFileVariable: 'CONTAINER_SSHKEY') | ||
| ]) { |
There was a problem hiding this comment.
Hmm, this seems odd in the library. It's specific to the pipeline. I'd personally prefer having it live in the pipeline as a separate function (and then here we can just pass in the user, host, and uid bits). At the very least, let's make them parameters instead of hardcoding the ID strings.
There was a problem hiding this comment.
moved bits to the pipeline in gp.groovy.
- Adds `runSingleCmd()` for running with `--singleCmd` - Adds error checking for `runSpec()`. - Converts existing `runGangplank()` into internal function `_runGangplank()` - Adds `runGangplank()`, switches between `runSingleCmd()` and `runSpec()` - Adds `_getArch()` for parsing out and adding `--arch=$arch`
dustymabe
force-pushed
the
dusty-gangplank-additions-pr
branch
from
d4e055c to
5820f10
Compare
|
The pipeline specific bits have been moved to the pipeline. Updated list of things done here: |
jlebon
approved these changes
Jul 28, 2021
This was referenced Jul 30, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds runSingleCmd and error checking for runSpec. Also adds
getGangPlankFCOSAARCH64Params()with a default set of params forrunning against the FCOS AARCH64 builder and
gangPlankFCOSAARCH64BuilderWrapper()with default setup andinvocation for executing gangplank against that builder.