Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-sys: Use new tier = 2 for cargo-vendor-filterer #1193

Merged
merged 1 commit into from
May 30, 2023

Conversation

cgwalters
Copy link
Member

This fixes the problem described in the comment.

This fixes the problem described in the comment.
@bgilbert
Copy link
Contributor

bgilbert commented May 23, 2023

Since this widens the set of platforms we're including, it could conceivably change the contents of the vendor tarball. Does it? If so, we should probably release-note the change to vendored platforms under "packaging changes".

Also, it looks like there are a few other packages that will need updates. Could you do those as well?

@cgwalters
Copy link
Member Author

Since this widens the set of platforms we're including, it could conceivably change the contents of the vendor tarball. Does it?

Just verified that there are no changes to the vendored crate set. It'd be surprising if there were - last I dug at this I didn't find any architecture-dependent crates, just platform dependent.

@bgilbert bgilbert added the skip-notes This PR does not need release notes label May 24, 2023
@bgilbert
Copy link
Contributor

Okay, cool. This LGTM; leaving open so we don't forget to update the other projects in #1193 (comment).

@bgilbert
Copy link
Contributor

Thanks for doing the other PRs. Once you get the Zincati one posted, I'll approve this.

@bgilbert bgilbert merged commit bed836b into coreos:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-notes This PR does not need release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants