Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COPR integration Makefile and add CI test for RPM building #782

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Add COPR integration Makefile and add CI test for RPM building #782

merged 2 commits into from
Feb 22, 2022

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Feb 15, 2022

commit d768073f4531ee3666a5206235d49fa83609c3f0
Date:   Tue Feb 15 12:23:37 2022 -0500

    Add COPR integration Makefile

    I'd like to enable auto-builds of this repo to
    https://copr.fedorainfracloud.org/coprs/g/CoreOS/continuous/ so it could
    eventually feed into
    https://github.com/coreos/fedora-coreos-tracker/issues/910.
commit b9e7ec2b3bbe79b9dcc79d70c69b5459b92d8957
Date:   Tue Feb 15 12:31:03 2022 -0500

    workflows: make TOOLCHAIN optional

    For a future test, I'd like to ensure that we're using the Rust tooling
    from Fedora. So let's make the rustup setup optional so we don't have to
    worry about which `rustc` is actually being used.

commit 6ef95ab3a648a225a0f3874e69d611feb6ce47ec
Date:   Tue Feb 15 12:37:30 2022 -0500

    workflows: add "RPM build" test

    Verify that we can build using purely Fedora packages. This will catch
    earlier any Rust packages we need to update or add in Fedora rather than
    find out at release time.

    It also ensures that the new continuous COPR builds will not break since
    we don't vendor there either.

I'd like to enable auto-builds of this repo to
https://copr.fedorainfracloud.org/coprs/g/CoreOS/continuous/ so it could
eventually feed into
coreos/fedora-coreos-tracker#910.
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should require the job in branch protection settings after this merges.

.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@jlebon
Copy link
Member Author

jlebon commented Feb 17, 2022

Updated! (Though didn't test it on my fork first, let's see what happens in CI here.)

.github/workflows/rpm.yml Outdated Show resolved Hide resolved
Verify that we can build using purely Fedora packages. This will catch
earlier any Rust packages we need to update or add in Fedora rather than
find out at release time.

It also ensures that the new continuous COPR builds will not break since
we don't vendor there either.
@jlebon jlebon merged commit 4a03808 into coreos:main Feb 22, 2022
@jlebon jlebon deleted the pr/copr branch February 22, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants