scripts: persist console kargs during installation #877
Conversation
| @@ -10,6 +10,9 @@ PERSIST_KERNEL_NET_PARAMS=("ipv6.disable" "net.ifnames" "net.naming-scheme") | |||
| # List from https://www.mankier.com/7/dracut.cmdline#Description-Network | |||
| PERSIST_DRACUT_NET_PARAMS=("ip" "ifname" "rd.route" "bootdev" "BOOTIF" "rd.bootif" "nameserver" "rd.peerdns" "biosdevname" "vlan" "bond" "team" "bridge" "rd.net.timeout.carrier" "coreos.no_persist_ip" "coreos.force_persist_ip") | |||
|
|
|||
| # Console params to persist | |||
| PERSIST_CONSOLE_PARAMS=("console") | |||
There was a problem hiding this comment.
I have mixed feelings about this. On the one hand, I think as a heuristic this makes sense (I know I suggested it myself at least once), but OTOH this is adding more kargs magic which increases the divide between the
coreos.instpath vs manual installs.I guess one thing that helps is that in the
coreos.instpath, we automatically reboot which strongly implies that the console setting should be the same.Maybe what would help too is if we had a
coreos-installer installoption like--copy-console-kargs. Then we could frame it as "thecoreos.instpath implies--copy-console-kargs, which can also be enabled in a manual install". (On that note, maybe we could even also have--copy-network-kargsand--copy-s390x-kargstoo and drain everything here into coreos-installer proper.)Anyway, not a blocker, just voicing some thoughts.
| @@ -97,7 +100,7 @@ for item in "${cmdline[@]}"; do | |||
| firstboot_args+="${item} " | |||
| fi | |||
| done | |||
| for param in "${PERSIST_S390X_PARAMS[@]}"; do | |||
| for param in "${PERSIST_CONSOLE_PARAMS[@]}" "${PERSIST_S390X_PARAMS[@]}"; do | |||
There was a problem hiding this comment.
For
consolekargs specifically, we should probably also delete all previous platform-defaultconsolekargs before persisting those from the live environment. Although the last one wins, non-last console kargs still have an effect, and it wouldn't be correct to say we're exactly matching the console kargs of the live environment.coreos-installer doesn't support deleting kargs by key only, but with a
--copy-console-kargs, it could learn to delete all the metal kargs (and not append any platform kargs) if it picks up anyconsolekargs from the live environment.
|
This change was an afterthought to #605, and it clearly has broader implications. Landing it now would change the behavior of console kargs before the new defaults land in coreos/fedora-coreos-config#1181, which would be confusing, especially for OCP 4.11. So I think we should at least defer this until after the upcoming coreos-installer release. |
If the user specified console= kargs to the live system, those should probably be persisted to the destination system as well.
|
This change probably needs some additional consideration before landing, and isn't a priority for now. Closing. |
If the user specified
console=kargs to the live system, those should probably be persisted to the destination system as well.