This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
kube-aws: add option to create a record for externalDNSName automatic… #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return fmt.Errorf("hostName cannot be blank when createRecordSet is true") | ||
| } | ||
|
|
||
| r53 := route53.New(c.session) |
There was a problem hiding this comment.
validateDNSSettings should take the route53 service as a parameter. As is done with validateExistingVPC, an interface should be stubbed out and used to exercise this codepath in the cluster unit tests.
cgag
force-pushed
the
route53-record-auto
branch
2 times, most recently
from
14da68a
to
6680579
Compare
If at all possible in the future, try to separate the commits out on a per/PR basis. If that can't be avoided for whatever reason, make a note of it in the PR that it depends on another PR being merged and possibly rebased under it, if changes are made. |
|
Otherwise, LGTM pending above comments. Great work cgag. |
Currently it's on the user to create a record, via Route53 or otherwise, in order to make the controller IP accessible via externalDNSName. This commit adds an option to automatically create a Route53 record in a given hosted zone. Related to: coreos#340, coreos#257
cgag
force-pushed
the
route53-record-auto
branch
from
6680579
to
b22430f
Compare
|
My bad. Dropped the key pair commit and fixed the commit message. |
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ally
Currently it's on the user to create a record, via Route53 or otherwise,
in order to make the controller IP accessible via externalDNSName. This
commit adds an option to automatically create a Route53 record in a given
hosted zone.