This repository has been archived by the owner on May 14, 2019. It is now read-only.
Migrate to etcd clientv3 #52
Comments
|
For context, etcd-operator does not support automated back-up for applications using v2 API. We wish to operate discovery.etcd.io with etcd-operator, and this path was mentioned by @xiang90 as being reasonable. |
|
Is this going to be acceptable with how discovery works? IIRC discovery is basically just an HTTP proxy/router. In the past (in discussing the move to GRPC) this was deemed as both unnecessary for etcd v3 as well as impossible with how the service currently works. |
|
Another migration path we've discussed is loosely emulating v2 over v3. |
This was referenced Jul 5, 2017
hexfusion
pushed a commit
that referenced
this issue
Sep 8, 2018
Preliminary work towards #52. Goal is having good test coverage on current code base, so that we can safely migrate to etcd v3. This does not change any client-facing interface (etcd v2). Highlighted changes are: - [X] Update vendors with latest etcd release, sync other upstream dependencies - [X] Remove test files in `vendor` - [X] Use Go 1.8.3 (required for integration tests with latest etcd) - Go 1.6<= won't build, Go 1.7<= will build but fail in CI - [X] Change Go version to 1.8.3 in `Dockerfile` - [X] Share states between handlers with context, **for integration testing** (avoids global vars) - [X] Remove `pkg/lockstring`, instead have mutex inside shared states between handlers - [X] Add handler integration tests with embedded etcd (available since v3.1) - [X] Add e2e tests with actual etcd cluster and discovery.etcd.io builds - [X] Set up CIs
5 tasks
philips
pushed a commit
to philips/etcd
that referenced
this issue
Apr 10, 2019
Fixes a bug where the isRoot missed the "." case. Add a bunch of tests on fundamental operation of Create/Set/Delete. Context: I want to use this package to run the discovery service against the v3 storage backend. The limited functionality already implemented should be sufficient to do this. coreos/discovery.etcd.io#52
philips
pushed a commit
to philips/etcd
that referenced
this issue
Apr 10, 2019
Add a bunch of tests on fundamental operation of Create/Set/Delete. Context: I want to use this package to run the discovery service against the v3 storage backend. The limited functionality already implemented should be sufficient to do this. coreos/discovery.etcd.io#52
|
Moved to etcd-io/etcd#10627 |
|
done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
\cc @xiang90 @heyitsanthony
The text was updated successfully, but these errors were encountered: