s390x: zVM Secure IPL enablement #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-dubrovskii
force-pushed
the
s390x_zvm_secure_boot
branch
from
821351b
to
414e9c6
Compare
nikita-dubrovskii
force-pushed
the
s390x_zvm_secure_boot
branch
from
414e9c6
to
b4a4e0e
Compare
jlebon
reviewed
Nov 14, 2023
os/20231024-s390x-zvm-secure-boot.md
Outdated
|
|
||
| It is the customer's responsibility to ensure that the security keys that are required by a guest are present on the destination system.Security keys are required on all members of a relocation domain where a guest might be relocated and later IPLed with the secure option. For more information, see [How to enable secure boot on the HMC](https://www.ibm.com/support/pages/how-enable-secure-boot-hmc). | ||
|
|
||
| ### The IPL device number and the SECURE option load parameters are set |
There was a problem hiding this comment.
This seems to detail how to turn on Guest Secure IPL day 2, which is much less interesting than day 1. I almost think we should remove that section entirely.
The bit about verifying that RHCOS booted in that mode is helpful though. We could keep that in a separate section under the Proposal header.
os/20231024-s390x-zvm-secure-boot.md
Outdated
|
|
||
| Assuming zVM is ready for secure boot, we can setup LOADDEV at installation time | ||
|
|
||
| ## coreos-installer |
There was a problem hiding this comment.
where? ))
os/20231024-s390x-zvm-secure-boot.md
Outdated
| ## coreos-installer | ||
| 1) Add new `coreos.inst.secureboot` karg and `--with-secure-boot` option. `coreos-installer-generator` appends the switch when karg is provided | ||
| 2) During isntallation we check for `--with-secure-boot` and use `vmcp` tool to set LOADDEV | ||
| 3) Add new systemd unit `coreos-installer-reboot-secure.service` to restart from LOADDEV or modify `coreos-installer-reboot.service` to do the same (which immediatly termintes running CoreOS VM) |
There was a problem hiding this comment.
I.e. a simple systemctl reboot won't work? It needs to be done via cp ipl loaddev? Is this true on reboots of the installed system too?
There was a problem hiding this comment.
Unfortunately we must use cp ipl loaddev. Luckily any subsequent reboot just works (until we shutdown zVM itself)
nikita-dubrovskii
force-pushed
the
s390x_zvm_secure_boot
branch
4 times, most recently
from
f96bcfa
to
5e54975
Compare
nikita-dubrovskii
changed the title
jlebon
reviewed
Nov 16, 2023
nikita-dubrovskii
force-pushed
the
s390x_zvm_secure_boot
branch
from
5e54975
to
68dc5ae
Compare
Signed-off-by: Nikita Dubrovskii <nikita@linux.ibm.com>
nikita-dubrovskii
force-pushed
the
s390x_zvm_secure_boot
branch
from
68dc5ae
to
275bfb1
Compare
nikita-dubrovskii
changed the title
jlebon
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.