Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

Commit

Permalink
Merge pull request #1862 from fanminshi/fix_e2e
Browse files Browse the repository at this point in the history
e2e: remove unused code in testEtcdBackupOperatorForS3Backup
  • Loading branch information
fanminshi committed Jan 18, 2018
2 parents 13b4b52 + ea3fe7d commit 51e0e7d
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions test/e2e/e2eslow/backup_restore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import (
"time"

api "github.com/coreos/etcd-operator/pkg/apis/etcd/v1beta2"
"github.com/coreos/etcd-operator/pkg/util/awsutil/s3factory"
"github.com/coreos/etcd-operator/pkg/util/etcdutil"
"github.com/coreos/etcd-operator/pkg/util/k8sutil"
"github.com/coreos/etcd-operator/pkg/util/retryutil"
Expand Down Expand Up @@ -145,11 +144,6 @@ func testEtcdBackupOperatorForS3Backup(t *testing.T, clusterName, operatorClient
// local testing shows that it takes around 1 - 2 seconds from creating backup cr to verifying the backup from s3.
// 4 seconds timeout via retry is enough; duration longer than that may indicate internal issues and
// is worthy of investigation.
s3cli, err := s3factory.NewClientFromSecret(f.KubeClient, f.Namespace, "", os.Getenv("TEST_AWS_SECRET"))
if err != nil {
t.Fatalf("failed create s3 client: %v", err)
}
defer s3cli.Close()
err = retryutil.Retry(time.Second, 4, func() (bool, error) {
reb, err := f.CRClient.EtcdV1beta2().EtcdBackups(f.Namespace).Get(eb.Name, metav1.GetOptions{})
if err != nil {
Expand Down

0 comments on commit 51e0e7d

Please sign in to comment.