This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
Add caveat regarding v2 API data. #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
lgtm |
|
this is already mentioned in limitation by the way: https://github.com/coreos/etcd-operator#limitations |
|
Ah, I see. Thanks anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're experimenting with the etcd operator on staging. We're only using it with reproducible data, but we wanted to test the backups all the same, and discovered that v2 data isn't backed up.
This is fine, since most people use the v3 API now anyway.
However, as a cluster operator I would like to disable v2, so consider this PR my +1 to #1315