This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 741
*: make default etcd version to 3.2.10 #1607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Has TLS issue with 3.2.9:
|
etcd upstream issues ref:
We have to work around the issue right now by providing FQDN in peer certs. |
Even after adding cluster domain into peer SAN, etcd server still occasionally rejected connection with error:
Still needs more investigation. |
Also high chance for this error:
|
f1186b6
to
281ddb4
Compare
281ddb4
to
dfecf70
Compare
fba4412
to
8441f67
Compare
All tests fixed |
fanminshi
reviewed
Nov 18, 2017
@@ -78,8 +78,9 @@ func NewEtcdRestore(restoreName, version string, size int, restoreSource api.Res | |||
}, | |||
Spec: api.RestoreSpec{ | |||
ClusterSpec: api.ClusterSpec{ | |||
Size: size, | |||
Version: version, | |||
BaseImage: "gcr.io/etcd-development/etcd", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if version is 3.0.x? Will this code find the right image?
maybe we should also pass in the base image as a param.
8441f67
to
38e9f76
Compare
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1396
Blockers: