Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

restore-operator: create service itself #1837

Merged
merged 1 commit into from
Jan 9, 2018
Merged

restore-operator: create service itself #1837

merged 1 commit into from
Jan 9, 2018

Conversation

hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented Jan 8, 2018 •
edited
Loading

address #1836

@hongchaodeng hongchaodeng changed the title [wip] restore-operator: create service itself restore-operator: create service itself Jan 8, 2018
@hongchaodeng
Copy link
Member Author

hongchaodeng commented Jan 8, 2018 •
edited
Loading

With this patch, now the operator generates a service:

Name:              etcd-restore-operator
Namespace:         default
Labels:            name=etcd-operator
Annotations:       <none>
Selector:          name=etcd-operator
Type:              ClusterIP
IP:                10.31.243.120
Port:              <unset>  19999/TCP
TargetPort:        19999/TCP
Endpoints:         10.28.4.149:19999

Note that the labels are inherited from the deployment automatically.

hasbro17
hasbro17 reviewed Jan 9, 2018
View reviewed changes
cmd/restore-operator/service.go
package main

import (
"github.com/coreos/etcd-operator/pkg/util/k8sutil"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group this import separately.

@hongchaodeng
Copy link
Member Author

@etcd-bot retest this please
issue: #1825

@hasbro17
Copy link
Contributor

hasbro17 commented Jan 9, 2018

LGTM.
Also, remove the service spec from the restore-operator deployment yaml
https://github.com/coreos/etcd-operator/blob/master/example/etcd-restore-operator/deployment.yaml#L31-L40

@hongchaodeng hongchaodeng merged commit 28e9fcf into coreos:master Jan 9, 2018
@hongchaodeng
Copy link
Member Author

removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hasbro17 hasbro17 hasbro17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hongchaodeng @hasbro17