This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
[WIP] e2e: increase wait retries for etcd restore cluster #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hongchaodeng you can increase the flakes by decrease the retries to 2. i was able to reproduce the issue much often like 50 percents of time. |
How did you find out? |
fanminshi
changed the title
|
Closing this due to unobvious reason |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local testing show that's restoring cluster came up too slowly. so the retry failed before cluster was able to complete. Increase the retry rate gives restoring etcd cluster more time to come up.
fixes #1825