Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

*: make each new member name unique #1875

Merged
merged 1 commit into from
Jan 23, 2018
Merged

*: make each new member name unique #1875

merged 1 commit into from
Jan 23, 2018

Conversation

hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented Jan 22, 2018 •
edited
Loading

address #1872

@hongchaodeng
Copy link
Member Author

With this PR:

NAME                             READY     STATUS    RESTARTS   AGE
etcd-operator-68fcc5886d-rfmvq   3/3       Running   0          1m
example-etcd-cluster-2885z       1/1       Running   0          32s
example-etcd-cluster-gghrm       1/1       Running   0          48s
example-etcd-cluster-w5q9s       1/1       Running   0          56s

@hongchaodeng hongchaodeng changed the title [WIP] *: make each new member name unique *: make each new member name unique Jan 23, 2018
@hongchaodeng
Copy link
Member Author

@etcd-bot test this please

@hongchaodeng
Copy link
Member Author

I have kept stress testing this patch and haven't seen a flake since yesterday: https://jenkins-etcd.prod.coreos.systems/view/operator/job/etcd-operator-flaketest/

@hongchaodeng hongchaodeng added this to the 0.9.0 milestone Jan 23, 2018
@hasbro17
Copy link
Contributor

LGTM

@hongchaodeng hongchaodeng merged commit 70d3bd7 into coreos:master Jan 23, 2018
@hongchaodeng hongchaodeng mentioned this pull request Jan 23, 2018
Closed
@xiang90
Copy link
Collaborator

xiang90 commented Jan 23, 2018

will this introduce any potential compatibility issue?

@hongchaodeng
Copy link
Member Author

@xiang90
Yes. User can upgrade from old version operators.

@hongchaodeng hongchaodeng removed this from the 0.9.0 milestone Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hongchaodeng @hasbro17 @xiang90