Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

CHANGELOG: update #1880

Merged

Conversation

hasbro17
Copy link
Contributor

[skip ci]

/cc @hongchaodeng

Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to mention the Alpha PV feature: #1861

CHANGELOG.md Outdated
@@ -4,6 +4,8 @@

### Changed

- Changed etcd pod member names to be unique by having a random suffix instead of a sequence number e.g `example-etcd-cluster-2885z`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare what it looked like before and looks now.
Also mention about compatibility.

@hongchaodeng
Copy link
Member

Also need to mention that we fixed a bug that restore might fail.

@hongchaodeng
Copy link
Member

It's mystic convention. But object name could not exceed 64 characters:
https://github.com/kubernetes/apimachinery/blob/1168e538ea3ccf444854d1fdd5681d2d876680a7/pkg/util/validation/validation.go#L33

We also need to subtract the five characters from it.

@hasbro17 hasbro17 force-pushed the haseeb/update-CHANGELOG-member-name-change branch 2 times, most recently from ec53d09 to d689bff Compare January 24, 2018 00:52
@hasbro17 hasbro17 changed the title CHANGELOG: highight unique member name change CHANGELOG: update Jan 24, 2018
@hasbro17 hasbro17 force-pushed the haseeb/update-CHANGELOG-member-name-change branch from d689bff to 5b84335 Compare January 24, 2018 18:54
@fanminshi
Copy link
Contributor

lgtm

@fanminshi fanminshi merged commit 69edfc8 into coreos:master Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants