This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
/cc @rjtsdl for abs changes. |
LGTM for S3 part. |
@fanminshi
|
@hongchaodeng that was my plan for the 4th bullet point #1906 |
@hongchaodeng yep, i can help on ABS ctx support. Do we want it in this PR? Or I can create a new one. |
@rjtsdl let's support abs ctx in a new pr. |
Manual test planCase: 1 second backup timeoutetcd size:
1 second timeout: apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdBackup"
metadata:
name: example-cluster-backup
spec:
etcdEndpoints: ['example-etcd-cluster-client:2379']
storageType: S3
backupPolicy:
TimeoutInSecond: 1
s3:
path: jenkins-testing-operator/vault.etcd.backup
awsSecret: aws output:
Case: 100 seconds backup timeoutetcd size:
100 backup timeout: apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdBackup"
metadata:
name: example-cluster-backup
spec:
etcdEndpoints: ['example-etcd-cluster-client:2379']
storageType: S3
backupPolicy:
TimeoutInSecond: 100
s3:
path: jenkins-testing-operator/vault.etcd.backup
awsSecret: aws output: $ kubectl -n backup get etcdbackups.etcd.database.coreos.com example-cluster-backup -o yaml
apiVersion: etcd.database.coreos.com/v1beta2
kind: EtcdBackup
metadata:
clusterName: ""
creationTimestamp: 2018-02-06T22:53:34Z
generation: 0
initializers: null
name: example-cluster-backup
namespace: backup
resourceVersion: "155599"
selfLink: /apis/etcd.database.coreos.com/v1beta2/namespaces/backup/etcdbackups/example-cluster-backup
uid: 8f8d58d9-0b90-11e8-b6a1-080027ae9197
spec:
backupPolicy:
timeoutInSecond: 100
etcdEndpoints:
- example-etcd-cluster-client:2379
s3:
awsSecret: aws
path: jenkins-testing-operator/vault.etcd.backup
storageType: S3
status:
etcdRevision: 52065
etcdVersion: 3.2.13
succeeded: true |
cc/ @hongchaodeng. Manually tested. |
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backup/writer interface now reasons about input context. The context controls the writer.Write operation.
ref: #1906