This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
Update dep to 0.4 and change respective rules #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update aws-sdk-go 1.13.8 0.4 dep rules will by default apply major range operator '^' on semantic versions. Thus we need to pin the version explicitly. For non-semantic version like tags this is fine.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dep to 0.4.1. Dep is developing fast and we better keep up with it to catch bug fix and also community docs.
0.4 dep rules will by default apply major range operator '^' on semantic versions. Thus we need to pin the version explicitly.
For non-semantic versions like tags this is fine.