-
Notifications
You must be signed in to change notification settings - Fork 741
Add cloud environment support for ABS backup #1981
Conversation
cc @xiang90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than question about the autorest package, this LGTM, but IANTM.
@@ -18,6 +18,7 @@ import ( | |||
"fmt" | |||
|
|||
"github.com/Azure/azure-sdk-for-go/storage" | |||
"github.com/Azure/go-autorest/autorest/azure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now it looks like go-autorest is a transient dependency, this seems to make it a direct dependency.
Should this include an update to Gopkg.toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not farmiliar with dep. Run dep ensure
doesn't add that. Should I add it explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add go-autorest. it is vendored already via https://github.com/coreos/etcd-operator/blame/master/Gopkg.lock#L17
I don't see a doc on how to use the ABS as the backup backend. Could you add a doc under |
lgtm on this code. |
@fanminshi there’s |
@mwieczorek good find. I think we should leave the design doc alone. Let's just copy and paste the design content and update it with more details on how to use ABS as the backend for public cloud, sovereign cloud, and etc. |
@fanminshi @mwieczorek Thanks. Let me add the user guide for it in a separate PR. |
PR #1842 adds support for ABS (Azure Blob Service) backup. But it always using AzurePublicCloud, so that other sovereign clouds (e.g. mooncake) won't work.
This PR adds an extra option
cloud
to ABS credential and usestorage.NewBasicClientOnSovereignCloud()
to fix the issue. Ifcloud
is not set, then AzurePublicCloud is used (same as before).Example ABS credential now is