This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
pkg/util: Don't expose unready nodes via client service #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@etcd-bot ok to test |
|
@hexfusion Any plans to merge this? |
|
Hi All, Thanks, |
|
@ckoehn sorry for the delay I will take a final look at this before the end of the week. |
|
@ckoehn Seems good to me. Can you please rebase from the master. |
Previously unready etcd nodes were already receiving client connections although they are still in the initiation phase and not able to accept any traffic. This caused connection failure or high latency. Fixes #2030 Signed-off-by: Christian Köhn <christian.koehn@figo.io>
|
@hasbro17 Done. Thanks for your review. |
hexfusion
approved these changes
Apr 17, 2019
kapouille
pushed a commit
to Polystream/etcd-operator
that referenced
this pull request
May 16, 2019
Previously unready etcd nodes were already receiving client connections although they are still in the initiation phase and not able to accept any traffic. This caused connection failure or high latency. Fixes coreos#2030 Signed-off-by: Christian Köhn <christian.koehn@figo.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously unready etcd nodes were already receiving client connections
although they are still in the initiation phase and not able to accept
any traffic. This caused connection failure or high latency.
Fixes #2030