-
Notifications
You must be signed in to change notification settings - Fork 741
Azure blob storage: use correct list prefix #2071
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
@etcd-bot ok to test |
@kapouille thanks for the PR. As we do not have testing for Azure setup can you provide a bit more details on how this resolves the situation? @rjtsdl I see you are with Oracle now but as a maintainer of Azure ABS feature could you please comment/review. |
of course @hexfusion . In order to list the existing backups and see which ones are out of date or not, it used to retrieve the wrong url, including the container name ( |
(apologies about the force-push, really should have done that work in a branch) |
Putting on hold, noticed an odd behaviour where it is keeping the oldest backups rather than the most recent. Investigating. |
Could not repro issue appears to be a one-off due to changing file naming conventions. |
@kapouille Sorry this has been open for a while. This seems good to me. Can you please rebase and also add a line in the Fixed section of the CHANGELOG for this. |
@kapouille pinging again to see if you have time to update the PR. If not then I can close this out and resubmit the bugfix. |
Apologies, will get on that tomorrow. |
I believe this is now done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Azure bloc storage implementation didn't use the right prefix resulting on no backup cleanup being performed.