This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
backup operator: enabled cluster wide operation. #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@etcd-bot ok to test |
|
@kapouille please review gofmt error [1] in the unit test, please. [1] https://jenkins-etcd-public.prod.coreos.systems/job/etcd-operator-unit-pr/1848/console |
kapouille
changed the title
|
Apologies, this needs more work (not only the gofmt issue). |
|
This should now be better. Had to fix an azure specific issue when handling very large backups. |
kapouille
changed the title
|
@kapouille Can you please rebase this PR as well. If you still have the time to work on this. |
Added cluster wide support to backup operator.
Very large files were previously loaded in-memory (causing fatal crashes).
kapouille
force-pushed
the
clusterwide-backup
branch
from
7e40295
to
dc17ae0
Compare
|
This should be fine now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cluster wide support to backup operator.