etcdctl: suggest endpoint over peers flag #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if peerstr == "" { | ||
| fmt.Println("warning: flag peers may not work in future releases; use endpoint") |
There was a problem hiding this comment.
flag --peers ... use flag --endpoint
for more clarity
|
I think we should just continue being backwards compatible and not break this. The flags and output are CoreOS API at this point. |
|
@philips Agree. |
|
lgtm |
xiang90
added a commit
that referenced
this pull request
Aug 28, 2015
etcdctl: suggest endpoint over peers flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ##3341
We still support
peersflag, but print out a warning.But I am not sure if someone would rely on the output of etcdctl... They should not though since we never try to maintain the same format for each release.
/cc @philips @robszumski @yichengq Any opinion on this?
Decision is to keep the pervious behavior