Update dependency on ugorji/go/codec #3655
Conversation
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| package client | |||
|
|
|||
| //go:generate codecgen -r "Node|Response|Nodes" -o keys.generated.go keys.go | |||
| //go:generate codecgen -d 1819 -r "Node|Response|Nodes" -o keys.generated.go keys.go | |||
There was a problem hiding this comment.
why do we need this? is the number supposed to be random when each time the code is generated?
There was a problem hiding this comment.
If you don't set it explicitly - the it is random based on the current time, which makes the generated code differ every time it's generated. I think having it always be the same is expected.
|
we use BTW, the format of commit title needs to be changed according to https://github.com/coreos/etcd/blob/master/CONTRIBUTING.md#format-of-the-commit-message |
wojtek-t
force-pushed
the
update_dependency
branch
from
250f8af
to
6b0d0cd
Compare
|
@yichengq - I'm not sure if I understood. What I've done to update it was: We also use Godeps in k8s and this is what we do there. Because of some reason that doesn't work here. Regardinc commit names - PTAL |
wojtek-t
force-pushed
the
update_dependency
branch
from
6b0d0cd
to
19aca61
Compare
Update ugorji/go/codec dependency to the newer version (a bunch of fixed were made).
Regenerate code for unmarshaling key response with a new version of ugorji/go/codec
wojtek-t
force-pushed
the
update_dependency
branch
from
19aca61
to
4eb598b
Compare
|
OK - it seems that the problem was with generated imports - I've changed on of those and it seems to work now. @yichengq - PTAL |
|
LGTM. Thanks for updating this! |
Update dependency on ugorji/go/codec
|
@yichengq - thanks! |
Rationale behind this change:
I are going to use ugorji/go/codec in Kubernetes too. However - in the version that you are currently using there were some issues (that k8s code discovered) and fixing them made some backward incompatible changes. And having k8s and etcd depend on different version of that dependency that are incompatible would be a nightmare.
@xiang90 @yichengq