-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: make set/delete one shot operations #5888
Conversation
/cc @yorkart |
is it easy to add a test for this? |
@xiang90 I think so; will add some integration tests around it |
tests added /cc @xiang90 |
lgtm |
) | ||
|
||
// TestV2NoRetryEOF tests destructive api calls won't retry on a disconnection. | ||
func TestV2NoRetryEOF(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing: shall we move this to client/integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like overkill, maybe if we add more tests in the future?
Old behavior would retry set and delete even if there's an error. This can lead to the client returning an error for deleting twice, instead of returning an error for an interdeterminate state. Fixes etcd-io#5832
54c9ee5
to
c30f89f
Compare
moved to |
lgtm |
Old behavior would retry set and delete even if there's an error. This
can lead to the client returning an error for deleting twice, instead
of returning an error for an interdeterminate state.
Fixes #5832