client: make set/delete one shot operations #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @yorkart |
|
is it easy to add a test for this? |
|
@xiang90 I think so; will add some integration tests around it |
|
tests added /cc @xiang90 |
|
lgtm |
| ) | ||
|
|
||
| // TestV2NoRetryEOF tests destructive api calls won't retry on a disconnection. | ||
| func TestV2NoRetryEOF(t *testing.T) { |
There was a problem hiding this comment.
one thing: shall we move this to client/integration?
There was a problem hiding this comment.
seems like overkill, maybe if we add more tests in the future?
Old behavior would retry set and delete even if there's an error. This can lead to the client returning an error for deleting twice, instead of returning an error for an interdeterminate state. Fixes etcd-io#5832
heyitsanthony
force-pushed
the
v2-one-shot
branch
from
54c9ee5
to
c30f89f
Compare
|
moved to |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old behavior would retry set and delete even if there's an error. This
can lead to the client returning an error for deleting twice, instead
of returning an error for an interdeterminate state.
Fixes #5832