Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Dockerfile: use 'ENTRYPOINT' instead of 'CMD'" #5937

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jul 14, 2016

Reverts #5876

Sorry, just found out

'ENTRYPOINT' does not allow other entry points, like

sudo docker run --name etcd quay.io/coreos/etcd:v3.0.2 -e "ETCDCTL_API=3" /usr/local/bin/etcdctl version

2016-07-14 01:30:18.199422 E | etcdmain: error verifying flags, '/usr/local/bin/etcdctl' is not a valid flag. See 'etcd --help'.

And change the default data directory to '/var/lib/etcd/'

This one works for both

sudo docker run --name etcd etcd_test /usr/local/bin/etcd

sudo docker exec etcd /bin/sh -c "/usr/local/bin/etcd --version"
sudo docker exec etcd /bin/sh -c "/usr/local/bin/etcdctl --version"

@xiang90
Copy link
Contributor

xiang90 commented Jul 14, 2016

lgtm

@gyuho gyuho merged commit c0cc161 into master Jul 14, 2016
@gyuho gyuho deleted the revert-5876-manual branch July 14, 2016 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants