Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: use /var/lib/etcd as default data dir #5935

Closed
wants to merge 1 commit into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jul 14, 2016

No description provided.

@gyuho
Copy link
Contributor Author

gyuho commented Jul 14, 2016

/cc @xiang90

@xiang90
Copy link
Contributor

xiang90 commented Jul 14, 2016

well... shall we just revert that pr then? what are the other stuff we have changed?

@gyuho
Copy link
Contributor Author

gyuho commented Jul 14, 2016

@xiang90 Yeah let's revert it. Here #5937.

And I think we should use /var/lib/etcd too, following this example? https://github.com/coreos/etcd/blob/master/contrib/systemd/etcd.service

@gyuho gyuho changed the title Dockerfile: change to 'CMD', '/var/lib/etcd' Dockerfile: use /var/lib/etcd as default data dir Jul 14, 2016
@xiang90
Copy link
Contributor

xiang90 commented Jul 14, 2016

what was it before? i do not want to change it if it was /var/etcd. it can break users after they use new image.

@gyuho
Copy link
Contributor Author

gyuho commented Jul 14, 2016

@xiang90 There was no default data dir before. It just mkdir -p /var/etcd.

If people run etcd in docker before without any flag, it will default to default.data.

@xiang90
Copy link
Contributor

xiang90 commented Jul 14, 2016

If you change the default data dir, then it breaks existing users. after they restart etcd with new image, they cannot find the old data-dir since the default location changed. no?

@gyuho
Copy link
Contributor Author

gyuho commented Jul 14, 2016

Yeah you are right. Let's keep it as it is now.

Thanks!

@gyuho gyuho closed this Jul 14, 2016
@gyuho gyuho deleted the docker-cmd branch July 14, 2016 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants