*: replace grpc-gateway endpoint with /v3 #9298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9298 +/- ##
=========================================
Coverage ? 75.58%
=========================================
Files ? 365
Lines ? 30695
Branches ? 0
=========================================
Hits ? 23202
Misses ? 5874
Partials ? 1619
Continue to review full report at Codecov.
|
|
lgtm. Defer to @xiang90 |
|
Well since I am here I am going to refactor the curl testing and probably break it out over a few different files. |
|
sgtm |
|
@xiang90 PTAL, if this seems reasonable I would like to get this merged and add the breakout test files in a new commit as this is quite large already. |
hexfusion
force-pushed
the
v3
branch
2 times, most recently
from
b701ede
to
1bd34ea
Compare
|
@xiang90 kind ping :) |
|
@hexfusion i am fine with this large commit. |
|
thank you |
hexfusion
added a commit
to hexfusion/etcd
that referenced
this pull request
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current /v3beta with the stable /v3 API. Currently, support for /v3beta is maintained for one minor iteration and will remove completely as of 3.5. This can be removed now but as we offered the convenience with the last bump I kept it in while completely removing /v3alpha.
I will attempt to improve e2e test coverage in a separate PR.
ref: #9189