Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: updates from #9298 #9321

Merged
merged 1 commit into from
Feb 14, 2018
Merged

CHANGELOG: updates from #9298 #9321

merged 1 commit into from
Feb 14, 2018

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Feb 13, 2018

added details to CHANGELOG for #9298

@hexfusion hexfusion changed the title *: update CHANGELOG-3.4 CHANGELOG: updates from #9298 Feb 13, 2018
@codecov-io
Copy link

Codecov Report

Merging #9321 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9321      +/-   ##
==========================================
- Coverage   75.82%   75.75%   -0.07%     
==========================================
  Files         365      365              
  Lines       30695    30695              
==========================================
- Hits        23274    23254      -20     
- Misses       5807     5824      +17     
- Partials     1614     1617       +3
Impacted Files Coverage Δ
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
etcdctl/ctlv3/command/lease_command.go 65.34% <0%> (-5.95%) ⬇️
clientv3/concurrency/session.go 88.63% <0%> (-4.55%) ⬇️
proxy/grpcproxy/watch.go 90.06% <0%> (-3.11%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
etcdserver/api/v3rpc/lease.go 83.78% <0%> (-2.71%) ⬇️
clientv3/concurrency/election.go 79.52% <0%> (-2.37%) ⬇️
internal/lease/leasehttp/http.go 63.97% <0%> (-1.48%) ⬇️
etcdserver/v3_server.go 81.49% <0%> (-0.78%) ⬇️
clientv3/watch.go 95.83% <0%> (-0.74%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd71b4...68c270d. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@gyuho gyuho merged commit e48b585 into etcd-io:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants