This repository has been archived by the owner on Jun 4, 2019. It is now read-only.
A set of changes to update etcdctl to use go-etcd 0.2 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's lightly tested and seems to work well. Note that I deleted sets.go because I'm planning to support sets operation at the etcd level. |
| const CompareAndSwapUsage = `usage: etcdctl [etcd flags] compareAndSwap <key> <value> [testAndSet flags] | ||
| either prevValue or prevIndex needs to be given | ||
| special flags: --ttl to set a key with ttl | ||
| --pvalue to set the previous value |
There was a problem hiding this comment.
I would prefer if the flags matched the params: prevvalue and previndex
|
@philips Sorry missed your message earlier. Fixed. |
|
@derekchiang Please only use lower case flags. It is pretty weird to have camel cased flags. |
|
@philips OK. |
philips
added a commit
that referenced
this pull request
Nov 12, 2013
A set of changes to update etcdctl to use go-etcd 0.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.