Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect "no action items from last meeting" suggestion #50

Open
travier opened this issue Dec 11, 2023 · 4 comments · May be fixed by #69
Open

Incorrect "no action items from last meeting" suggestion #50

travier opened this issue Dec 11, 2023 · 4 comments · May be fixed by #69
Labels
jira for syncing to jira

Comments

@travier
Copy link
Member

travier commented Dec 11, 2023

In https://discussion.fedoraproject.org/t/fedora-coreos-community-meeting-minutes-2023-11-22/96760, we got two action items and they were not reported in #49 and got dropped.

@prestist
Copy link
Contributor

Interesting, I suspect its because of the format change over from matrix?

@prestist
Copy link
Contributor

I know the regex needs to be checked/updated to ensure that the action works with the new matrix bot. Since any changes could cause the regex to not find any action items.

@prestist prestist added the jira for syncing to jira label Jan 26, 2024
@prestist
Copy link
Contributor

prestist commented Feb 2, 2024

With the latest changes, it seems we are still encountering an issue with the latest code.

'Failed: to get action items, check the last meeting notes.' This looks like we are bailing when fetching. So while fetching, lets also at the minimum improve the error to direct to the correct URL. To manually check.

@prestist
Copy link
Contributor

prestist commented Feb 2, 2024

Also while looking at the action, lets see about improving how it generates the URL.

Currently its fairly fragile and simply going back 7 days from the date. This was due to data storage changes the new matrix bot uses now. Put simply the new bot adds another directory which is a date.

prestist added a commit to prestist/fcos-meeting-action that referenced this issue Feb 6, 2024
With the latest change, we had to introduce a very fragile concept.
Where we looked 7 days prior to capture the last weeks meeting.
Instead remove this, and iterate through each folder to capture the
last meeting. More work but should reduce fragileness.

Additonally action items were not being correctly matched. Update
regex for actionItems.

fixes: coreos#50
prestist added a commit to prestist/fcos-meeting-action that referenced this issue Feb 6, 2024
With the latest change, we had to introduce a very fragile concept.
Where we looked 7 days prior to capture the last weeks meeting.
Instead remove this, and iterate through each folder to capture the
last meeting. More work but should reduce fragileness.

Additonally action items were not being correctly matched. Update
regex for actionItems.

fixes: coreos#50
prestist added a commit to prestist/fcos-meeting-action that referenced this issue Feb 6, 2024
With the latest change, we had to introduce a very fragile concept.
Where we looked 7 days prior to capture the last weeks meeting.
Instead remove this, and iterate through each folder to capture the
last meeting. More work but should reduce fragileness.

Additonally action items were not being correctly matched. Update
regex for actionItems.

fixes: coreos#50
prestist added a commit to prestist/fcos-meeting-action that referenced this issue Feb 6, 2024
With the latest change, we had to introduce a very fragile concept.
Where we looked 7 days prior to capture the last weeks meeting.
Instead remove this, and iterate through each folder to capture the
last meeting. More work but should reduce fragileness.

Additonally action items were not being correctly matched. Update
regex for actionItems.

fixes: coreos#50
prestist added a commit to prestist/fcos-meeting-action that referenced this issue Feb 6, 2024
With the latest change, we had to introduce a very fragile concept.
Where we looked 7 days prior to capture the last weeks meeting.
Instead remove this, and iterate through each folder to capture the
last meeting. More work but should reduce fragileness.

Additonally action items were not being correctly matched. Update
regex for actionItems.

fixes: coreos#50
@prestist prestist linked a pull request Feb 6, 2024 that will close this issue
prestist added a commit to prestist/fcos-meeting-action that referenced this issue Feb 6, 2024
With the latest change, we had to introduce a very fragile concept.
Where we looked 7 days prior to capture the last weeks meeting.
Instead remove this, and iterate through each folder to capture the
last meeting. More work but should reduce fragileness.

Additonally action items were not being correctly matched. Update
regex for actionItems.

fixes: coreos#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira for syncing to jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants