-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping updates #31
Conversation
Since meeting topics can be added on wendsday, lets move the creation of the issue to right before the meeting, while leaving enough time to ensure the issue is valid/created.
e6b3da7
to
ca8e9a8
Compare
3f6b3a3
to
eab3ebf
Compare
eab3ebf
to
41205f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dustymabe When you get the chance could I get a review on this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial LGTM
@@ -20,7 +20,7 @@ export async function run(): Promise<void> { | |||
|
|||
const issueBody = hydrateIssueTemplate(actionItems, meetingTopics) | |||
console.log('Create issue') | |||
createThisReposIssue('Fedora CoreOS Weekly Meeting', issueBody) | |||
createThisReposIssue(issueBody) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we somehow losing Fedora CoreOS Weekly Meeting
in the issue title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda; so this was an artifact of me not understanding actions well. I was passing a lot of values through via the go function signatures; but eventually I learned that you could run it via a config file. and so the "createissue" func was in a mixed state of using signatures and accepting the config file.
I can change it back to "Fedora CoreOS Weekly Meeting" but in this process I also did change the title to 'FCOS Meeting Checklist' ; thought is might be more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also did change the title to 'FCOS Meeting Checklist' ; thought is might be more appropriate?
+1 - works for me. You should be good to merge this.
No description provided.