Skip to content

Commit

Permalink
manifests: Split container engines into sub-manifests
Browse files Browse the repository at this point in the history
- Split podman, moby-engine and related packages into distinct
  sub-manifests
- Include both container engines by default
  • Loading branch information
travier committed Feb 27, 2024
1 parent a736167 commit 4b4f032
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 17 deletions.
5 changes: 0 additions & 5 deletions manifests/fedora-coreos-base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ postprocess:
- |
#!/usr/bin/env bash
set -xeuo pipefail
setsebool -P -N container_use_cephfs on # RHBZ#1692369
setsebool -P -N virt_use_samba on # RHBZ#1754825
# Mask dnsmasq. We include dnsmasq for host services that use the dnsmasq
Expand Down Expand Up @@ -179,12 +178,9 @@ packages:
# - Add this package on x86_64 and aarch64 (the two architectures
# GCP supports. https://github.com/coreos/fedora-coreos-tracker/issues/1494
# This should be moved to a shared manifest when RHEL has this package.
# - crun-wasm wasmedge-rt
# - Support for wasm runtime: https://github.com/coreos/fedora-coreos-tracker/issues/1375
packages-x86_64:
- irqbalance
- google-compute-engine-guest-configs-udev
- crun-wasm wasmedge-rt
# Include AMD microcode updates, see https://github.com/coreos/fedora-coreos-tracker/issues/1618.
# This normally should belong in bootable-rpm-ostree.yaml (alongside
# `microcode_ctl`), but this change hasn't hit RHCOS yet.
Expand All @@ -199,7 +195,6 @@ packages-aarch64:
- irqbalance
- qemu-user-static-x86
- google-compute-engine-guest-configs-udev
- crun-wasm wasmedge-rt
packages-s390x:
- qemu-user-static-x86

Expand Down
19 changes: 13 additions & 6 deletions manifests/fedora-coreos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ rojig:
add-commit-metadata:
fedora-coreos.stream: ${stream}

# Include all container engines by default
variables:
container_engines: true

include: fedora-coreos-base.yaml
conditional-include:
Expand All @@ -27,17 +30,25 @@ conditional-include:
# passwd RPM was obsoleted by shadow-utils in F40+, but we need to keep
# including it in F39. Remove this when we are on F40+ on all streams.
include: passwd.yaml
- if: releasever == 39
- if:
- releasever == 39
- container_engines == true
# No longer need CNI plugins in f40 since Podman dropped
# support for CNI networking entirely in Podmanv5
# Remove this once we have Podman v5 in f39.
# xref: https://github.com/coreos/fedora-coreos-tracker/issues/1629
include: cni-plugins.yaml
- if: releasever == 39
- if:
- releasever == 39
- container_engines == true
# Checks for breaking changes that came with Podman v5.
include: podman-v5.yaml
- if: releasever >= 40
include: cliwrap.yaml
- if: container_engines == true
include:
- podman.yaml
- moby-engine.yaml

ostree-layers:
- overlay/15fcos
Expand All @@ -55,10 +66,6 @@ packages:
# the archive repo for more reliable package layering
# https://github.com/coreos/fedora-coreos-tracker/issues/400
- fedora-repos-archive
# CL ships this.
- moby-engine
# Already pulled in by moby-engine, but let's be explicit. Typhoon uses it.
- containerd
# Updates
- zincati
# Include and set the default editor
Expand Down
6 changes: 6 additions & 0 deletions manifests/moby-engine.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
packages:
# CL shipped this
- moby-engine
# Already pulled in by moby-engine, but let's be explicit. Typhoon uses it.
- containerd
- runc
19 changes: 19 additions & 0 deletions manifests/podman.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
packages:
- podman
- crun
# Include toolbox here as it pulls podman
- toolbox

# Support for wasm runtime: https://github.com/coreos/fedora-coreos-tracker/issues/1375
packages-x86_64:
- crun-wasm wasmedge-rt
packages-aarch64:
- crun-wasm wasmedge-rt

postprocess:
# Enable SELinux booleans used by OpenShift
# https://github.com/coreos/fedora-coreos-tracker/issues/284
- |
#!/usr/bin/env bash
set -xeuo pipefail
setsebool -P -N container_use_cephfs on # RHBZ#1692369
9 changes: 3 additions & 6 deletions manifests/user-experience.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,10 @@ packages:
# Remote Access
- openssh-clients openssh-server
# Container tooling
## crun recommends but doesn't require criu and criu-libs. We want them for
## checkpoint/restore. https://github.com/coreos/fedora-coreos-tracker/issues/1370
- crun criu criu-libs
- podman
- runc
- skopeo
- toolbox
# crun recommends but doesn't require criu and criu-libs. We want them for
# checkpoint/restore. https://github.com/coreos/fedora-coreos-tracker/issues/1370
- criu criu-libs
# passt provides user-mode networking daemons for namespaces
- passt
# nvme-cli for managing nvme disks
Expand Down

0 comments on commit 4b4f032

Please sign in to comment.