tests: ignition.kargs.basic: rework test

- Add description - Convert Ignition to Butane - Use ok/fatal from commonlib.sh
coreos · Feb 2, 2022 · 65e8e55 · 65e8e55
1 parent 486baae
commit 65e8e55
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 17 deletions.
diff --git a/tests/kola/ignition/kargs/basic/config.bu b/tests/kola/ignition/kargs/basic/config.bu
@@ -0,0 +1,7 @@
+variant: fcos
+version: 1.4.0
+kernel_arguments:
+  should_exist:
+    - foobar
+  should_not_exist:
+    - mitigations=auto,nosmt
diff --git a/tests/kola/ignition/kargs/basic/config.ign b/tests/kola/ignition/kargs/basic/config.ign
diff --git a/tests/kola/ignition/kargs/basic/data/commonlib.sh b/tests/kola/ignition/kargs/basic/data/commonlib.sh
@@ -0,0 +1 @@
+../../../../data/commonlib.sh
diff --git a/tests/kola/ignition/kargs/basic/test.sh b/tests/kola/ignition/kargs/basic/test.sh
@@ -1,14 +1,8 @@
 #!/bin/bash
 set -xeuo pipefail
+# This test runs on all platforms and verifies Ignition kernel argument setting.
 
-ok() {
-    echo "ok" "$@"
-}
-
-fatal() {
-    echo "$@" >&2
-    exit 1
-}
+. $KOLA_EXT_DATA/commonlib.sh
 
 if ! grep foobar /proc/cmdline; then
     fatal "missing foobar in kernel cmdline"