Skip to content

Commit

Permalink
tests/kdump: bump timeout for kdump.service
Browse files Browse the repository at this point in the history
Saw a CI run timeout because `kdump.service` took 65s to build its
initramfs but we only wait 60s. Let's just bump this to have a larger
margin of error.
  • Loading branch information
jlebon authored and dustymabe committed May 16, 2024
1 parent 0819fd9 commit 6d7dd37
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions tests/kola/data/commonlib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ cmdline_arg() {

# wait for ~60s when in activating status
is_service_active() {
local service="$1"
for _x in {0..60}; do
local service="$1"; shift
local timeout="${1:-60}"; shift
for _x in $(seq "${timeout}"); do
[ "$(systemctl is-active "${service}")" != "activating" ] && break
sleep 1
done
Expand Down
4 changes: 3 additions & 1 deletion tests/kola/kdump/crash/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ set -xeuo pipefail

case "${AUTOPKGTEST_REBOOT_MARK:-}" in
"")
if ! is_service_active kdump.service; then
# use 120s for this since kdump can take a while to build its initramfs,
# especially if the system is loaded
if ! is_service_active kdump.service 120; then
fatal "kdump.service failed to start"
fi
# Verify that the crashkernel reserved memory is large enough
Expand Down

0 comments on commit 6d7dd37

Please sign in to comment.