Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s390x: ext.config.disks.lvmdevices fails ocassionally #2807

Closed
jschintag opened this issue Jan 17, 2024 · 2 comments · Fixed by #2811
Closed

s390x: ext.config.disks.lvmdevices fails ocassionally #2807

jschintag opened this issue Jan 17, 2024 · 2 comments · Fixed by #2811

Comments

@jschintag
Copy link
Contributor 

22:33:11  Jan 16 21:33:04 qemu0 kola-runext-lvmdevices[2151]: + pvcreate --devicesfile= /dev/vda /dev/vdb
22:33:11  Jan 16 21:33:04 qemu0 kola-runext-lvmdevices[2153]:   Cannot use /dev/vdb: device is partitioned
22:33:11  Jan 16 21:33:06 qemu0 kola-runext-lvmdevices[2153]:   Physical volume "/dev/vda" successfully created.

Probable cause is that on s390x /dev/vda and such are not always guaranteed to be the same disk. This most likely resulted in the above example, where /dev/vdb is likely the root partition.
@jlebon
Copy link
Member

jlebon commented Jan 17, 2024

Should check if there are /dev/disk/by-* symlinks that we could use instead. More explicitly, additionalDisks supports specifying a serial name, which then shows up IIRC under something like /dev/disk/by-id/virtio-$NAME.

jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Jan 18, 2024
@jlebon
kola/lvmdevices: use serial to reference disks
c069c6e 
Using `/dev/vda`/`/dev/vdb` to refer to attached disks in inherently
unreliable since the order may change across e.g. OS or QEMU versions.

Slap on a serial name instead and refer to it that way. Interestingly,
it seems like the LVM tooling also picks up on this and bases its entry
in the `lvmdevices` file on the device serial.

Closes: coreos#2807
@jlebon jlebon mentioned this issue Jan 18, 2024
Merged
@jlebon
Copy link
Member

jlebon commented Jan 18, 2024

Should be fixed by #2811.

jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Jan 18, 2024
@jlebon
kola/lvmdevices: use serial to reference disks
2b1f9c0 
Using `/dev/vda`/`/dev/vdb` to refer to attached disks in inherently
unreliable since the order may change across e.g. OS or QEMU versions.

Slap on a serial name instead and refer to it that way. Interestingly,
it seems like the LVM tooling also picks up on this and bases its entry
in the `lvmdevices` file on the device serial.

Closes: coreos#2807
dustymabe pushed a commit that referenced this issue Jan 18, 2024
@jlebon @dustymabe
kola/lvmdevices: use serial to reference disks
c84c4ef 
Using `/dev/vda`/`/dev/vdb` to refer to attached disks in inherently
unreliable since the order may change across e.g. OS or QEMU versions.

Slap on a serial name instead and refer to it that way. Interestingly,
it seems like the LVM tooling also picks up on this and bases its entry
in the `lvmdevices` file on the device serial.

Closes: #2807
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 18, 2024
@jlebon @aaradhak
kola/lvmdevices: use serial to reference disks
930e56c 
Using `/dev/vda`/`/dev/vdb` to refer to attached disks in inherently
unreliable since the order may change across e.g. OS or QEMU versions.

Slap on a serial name instead and refer to it that way. Interestingly,
it seems like the LVM tooling also picks up on this and bases its entry
in the `lvmdevices` file on the device serial.

Closes: coreos#2807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kola/lvmdevices: use serial to reference disks jlebon/fedora-coreos-config
2 participants
@jlebon @jschintag