-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rawhide] Switch to ostree-format: "oci" #1097
Conversation
Part of coreos/fedora-coreos-tracker#812 In this initial step, we're merely switching the internal tarball to be a different format. A future step will change the FCOS pipeline to automatically push this container to quay.io.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
two questions:
|
Good catch! Indeed, we'll need to adapt the upgrade test for this.
I think for this type of stuff it makes a lot of sense to start off on mechanical streams before propagating to development and then production streams. I don't see a reason why we wouldn't propagate once it's sanity-checked in rawhide. (I guess at some point we should just flip the cosa default?) |
OK this blocks on coreos/coreos-assembler#2300 |
I see an issue in rawhide building - possibly related to this?
|
I suspect this is just ye olde coreos/coreos-assembler#972 |
This is the RHCOS version of coreos/fedora-coreos-config#1097 I was hoping to land this in FCOS first but I'm kind of blocked on that in coreos/fedora-coreos-pipeline#359, so let's settle for parallel. NOTE! This **does not change** the effect of `cosa upload-oscontainer` etc. Some discussion on that here: ostreedev/ostree-rs-ext#23 and I will file more issues related to that. However, what this *will* do is allow us to push this *additional* image arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g. work. In other words to start this will just be something *we* use to quickly inspect rhcos-as-container, not something we actually ship. (OK that's kind of a lie, it will end up in a place like e.g. http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/ instead of the existing `ostree.tar` so in theory other people outside of our group could run it too, but 🤫)
This is the RHCOS version of coreos/fedora-coreos-config#1097 I was hoping to land this in FCOS first but I'm kind of blocked on that in coreos/fedora-coreos-pipeline#359, so let's settle for parallel. NOTE! This **does not change** the effect of `cosa upload-oscontainer` etc. Some discussion on that here: ostreedev/ostree-rs-ext#23 and I will file more issues related to that. However, what this *will* do is allow us to push this *additional* image arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g. work. In other words to start this will just be something *we* use to quickly inspect rhcos-as-container, not something we actually ship. (OK that's kind of a lie, it will end up in a place like e.g. http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/ instead of the existing `ostree.tar` so in theory other people outside of our group could run it too, but 🤫)
This is the RHCOS version of coreos/fedora-coreos-config#1097 I was hoping to land this in FCOS first but I'm kind of blocked on that in coreos/fedora-coreos-pipeline#359, so let's settle for parallel. NOTE! This **does not change** the effect of `cosa upload-oscontainer` etc. Some discussion on that here: ostreedev/ostree-rs-ext#23 and I will file more issues related to that. However, what this *will* do is allow us to push this *additional* image arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g. work. In other words to start this will just be something *we* use to quickly inspect rhcos-as-container, not something we actually ship. (OK that's kind of a lie, it will end up in a place like e.g. http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/ instead of the existing `ostree.tar` so in theory other people outside of our group could run it too, but 🤫)
This is the RHCOS version of coreos/fedora-coreos-config#1097 I was hoping to land this in FCOS first but I'm kind of blocked on that in coreos/fedora-coreos-pipeline#359, so let's settle for parallel. NOTE! This **does not change** the effect of `cosa upload-oscontainer` etc. Some discussion on that here: ostreedev/ostree-rs-ext#23 and I will file more issues related to that. However, what this *will* do is allow us to push this *additional* image arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g. work. In other words to start this will just be something *we* use to quickly inspect rhcos-as-container, not something we actually ship. (OK that's kind of a lie, it will end up in a place like e.g. http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/ instead of the existing `ostree.tar` so in theory other people outside of our group could run it too, but 🤫)
Part of coreos/fedora-coreos-tracker#812
In this initial step, we're merely switching the internal
tarball to be a different format.
A future step will change the FCOS pipeline to automatically
push this container to quay.io.