Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

35coreos-ignition: skip reboot if changed kargs match current boot #1409

Open
wants to merge 6 commits into
base: testing-devel
Choose a base branch
from
Open

35coreos-ignition: skip reboot if changed kargs match current boot #1409

wants to merge 6 commits into from

Commits on Mar 18, 2022

  1. 35coreos-ignition: skip reboot if changed kargs match current boot 

    If the requested kernel arguments in the Ignition config already match
the kernel arguments of the currently booted system then let's skip
the reboot because the reboot won't change anything.

One example of a use of this would be if someone is doing a PXE install
and they want to persistently use `net.ifnames=0`. They apply
`net.ifnames=0` on the PXE boot and coreos-installer transparently
forwards it to the Ignition boot (for a single boot). Then the Ignition
config has `net.ifnames=0` set in the kernel arguments section.
ignition-kargs.service will take care of setting it persistently,
but without this change the system will be rebooted. With this change
we skip the reboot.
    @dustymabe
    dustymabe committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b565855 View commit details
    Browse the repository at this point in the history

  2. 35coreos-ignition: handle the case where booted kargs don't match des… 

    …ired

Today when you boot a system it's possible a value for a karg you
specified in the Ignition config matches the BLS config but not the
kargs from the current boot (in /proc/cmdline). Let's detect this and
reboot in that case too.
    @dustymabe
    dustymabe committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    a18120a View commit details
    Browse the repository at this point in the history

  3. tests: rename the ignition.kargs test to ignition.kargs.basic 

    We're going to add more tests here so let's put this one under
a subheading.
    @dustymabe
    dustymabe committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    6d11882 View commit details
    Browse the repository at this point in the history

  4. tests: ignition.kargs.basic: rework test 

    - Add description
- Convert Ignition to Butane
- Use ok/fatal from commonlib.sh
    @dustymabe
    dustymabe committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    2bcebfe View commit details
    Browse the repository at this point in the history

  5. tests: add ignition.kargs.skipreboot test 

    This test verifies that if a kernel argument that is set as "should_exist"
in the Ignition config already exists on the kernel command line of the machine
then we can skip the reboot when applying kernel arguments but we must still
update the BLS configs to make it permanent.
    @dustymabe
    dustymabe committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    d6e945b View commit details
    Browse the repository at this point in the history

  6. tests: add reboot check to ignition.kargs.basic 

    This will further sanity check the karg persists even to subsequent
boots.
    @dustymabe
    dustymabe committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    83f3df2 View commit details
    Browse the repository at this point in the history