-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: Add container-cmd
#1484
Conversation
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
OK, rebased 🏄 and this should be good to merge now that we have a new enough rpm-ostree. |
OK CI flaked on the journal bit, but this can't break kola tests anyways. |
Not sure If I have these perms for this repo, but I'll give it a try: /lgtm |
Seems like this would be shared across all streams, right? In that case, maybe let's put it in |
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
Ah yes, thank you! |
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
Builds on coreos/rpm-ostree#3402
Relates to coreos/coreos-assembler#2685
Basically, source of truth for the CMD moves from being hardcoded
in cosa hackiliy to being part of the ostree commit, which means
it survives a full round trip of
ostree → container → ostree → container