manifest: Add container-cmd
#1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Feb 4, 2022
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
This was referenced Feb 4, 2022
Merged
|
OK, rebased 🏄 and this should be good to merge now that we have a new enough rpm-ostree. |
|
OK CI flaked on the journal bit, but this can't break kola tests anyways. |
cheesesashimi
previously approved these changes
Mar 8, 2022
|
Not sure If I have these perms for this repo, but I'll give it a try: /lgtm |
|
Seems like this would be shared across all streams, right? In that case, maybe let's put it in |
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
Ah yes, thank you! |
jlebon
approved these changes
Mar 8, 2022
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Mar 8, 2022
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Mar 22, 2022
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
jlebon
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 23, 2022
Depends coreos/fedora-coreos-config#1484 Also while we have the patient open, use the new preferred verb `encapsulate` instead of `export`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on coreos/rpm-ostree#3402
Relates to coreos/coreos-assembler#2685
Basically, source of truth for the CMD moves from being hardcoded
in cosa hackiliy to being part of the ostree commit, which means
it survives a full round trip of
ostree → container → ostree → container