05core: drop 64-gce-disk-removal.rules #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a disk is yanked out of the machine, this rule provides different behavior on GCP than on other platforms. It doesn't meaningfully affect functionality, so let's remove the rule for consistency.
cgwalters
approved these changes
Sep 12, 2019
miabbott
approved these changes
Sep 13, 2019
There was a problem hiding this comment.
We got a reply from the reporter on the downstream BZ; he confirmed their product does not need the removal rule.
Additionally, I was able to run the suggested test suite on an RHCOS GCP image that has the rule included and it passed, so the rule seems inconsequential.
All to to say, LGTM. :)
I'll also mention I filed a BZ with the google-compute-engine-tools package in Fedora to get the udev rules in a separate package.
dustymabe
pushed a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 19, 2024
* FAQ: AsciiDoc fixes Fixes: b18cf11 add item to the FAQ about version numbers (coreos#151) * Remove double and end of line spaces This is necessary as this triggers unwanted warnings during translation in Weblate. * Remove 'experimental' attribute from all pages This attribute is only necessary if experimental Antora features are used which is not the case here. * Remove empty pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a disk is yanked out of the machine, this rule provides different behavior on GCP than on other platforms. It doesn't meaningfully affect functionality, so let's remove the rule for consistency.
See discussion in the original PR.