Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/kola/ignition: rename resource.s3 to .authenticated-s3; document kola options #1723

Merged
merged 3 commits into from
May 7, 2022
Merged

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented May 7, 2022

Make it clearer that the purpose of the test is to check authenticated S3 access.

dustymabe
dustymabe previously approved these changes May 7, 2022
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@bgilbert bgilbert enabled auto-merge (rebase) May 7, 2022 04:58
@bgilbert bgilbert merged commit 15e0ed1 into coreos:testing-devel May 7, 2022
@bgilbert bgilbert deleted the s3/testing-devel branch May 10, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants