Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/kola: Test disabling units via Ignition #1736

Merged
merged 1 commit into from
May 18, 2022
Merged

test/kola: Test disabling units via Ignition #1736

merged 1 commit into from
May 18, 2022

Conversation

travier
Copy link
Member

@travier travier commented May 12, 2022

sohankunkerkar
sohankunkerkar reviewed May 12, 2022
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!
code LGTM, I think CI needs the latest version of Ignition (v2.14.0)

@bgilbert
Copy link
Contributor

LGTM pending Ignition update.

dustymabe
dustymabe previously approved these changes May 16, 2022
View reviewed changes
@bgilbert
Copy link
Contributor

Needs rebase to pick up Ignition fast-track.

@travier
Copy link
Member Author

travier commented May 18, 2022

Rebased

@travier travier merged commit b862d0f into coreos:testing-devel May 18, 2022
@travier travier deleted the disable branch May 18, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgilbert bgilbert bgilbert approved these changes

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@dustymabe dustymabe dustymabe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@travier @bgilbert @dustymabe @sohankunkerkar