manifests/group: fix ID for "input" group #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the static GID for the `input` group, properly using the Fedora-wide reserved ID `104`. This group is mostly used as the owner of ephemeral entries under `/dev`, thus it should be safe to update (upon booting into the new deployment, devices will get created from scratch with the new GID). Ref: https://pagure.io/setup/blob/108f62338e57652bb3a37e9028572704f3f28c29/f/uidgid#_113
|
This is mostly like #1832. Should be good. Same mixed feelings. Hopefully we don't break someone's workflow. |
|
LGTM, but needs someone else to double check that we're not going to break things. |
jlebon
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Since it's used to create device nodes on boot, I agree this is safe to change.
LGTM, but needs someone else to double check that we're not going to break things.
I think one way to see this is that given that the group is actively used by the system, it's owned by us. And the GID we're moving it to is below SYS_GID_MIN so shouldn't be presently used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the static GID for the
inputgroup, properly using theFedora-wide reserved ID
104.This group is mostly used as the owner of ephemeral entries under
/dev, thus it should be safe to update (upon booting into the newdeployment, devices will get created from scratch with the new GID).
Ref: https://pagure.io/setup/blob/108f62338e57652bb3a37e9028572704f3f28c29/f/uidgid#_113
Ref: coreos/fedora-coreos-tracker#1201 (comment)