manifests/passwd: align 'nologin' shell path with systemd defaults #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates all relevant shell fields to use `/usr/sbin/nologin`. After the `/usr` hierarchy merge that happened in Fedora 17, the `nologin` binary is now effectively located under `/usr/sbin/`. For this reason, `systemd-sysusers` directly uses the latter path as the default shell for system users. While semantically equivalent, updating all entries to the new location ensures that defaults are matching across all components. In turn, that allows packages to avoid specifying a custom `nologin` shell in sysusers.d fragment, and just rely on systemd defaults. Refs: * https://fedoraproject.org/wiki/Features/UsrMove * https://github.com/systemd/systemd/blob/v251/meson.build#L633 * https://pagure.io/setup/pull-request/40
travier
approved these changes
Aug 2, 2022
|
@dustymabe just highlighting that we merged this changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all relevant shell fields to use
/usr/sbin/nologin.After the
/usrhierarchy merge that happened in Fedora 17, thenologinbinary is now effectively located under/usr/sbin/.For this reason,
systemd-sysusersdirectly uses the latter pathas the default shell for system users.
While semantically equivalent, updating all entries to the new
location ensures that defaults are matching across all components.
In turn, that allows packages to avoid specifying a custom
nologinshell in sysusers.d fragment, and just rely on systemd defaults.
Refs: