fedora-coreos-base: add in toolbox #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIUC toolbox does not currently handle all of our use cases but it will in the future so let's go ahead and include it so we can fix coreos/fedora-coreos-tracker#38 and work through the issues. |
|
Note that there is a current issue to work out but is being worked on: containers/toolbox#267 |
|
weird CI issue: |
|
cc @cgwalters for input |
|
also has anyone seen these deprecation warnings: |
|
Yeah, they started appearing recently. Thought we maybe just needed a libdnf bump though that's not it (opened coreos/rpm-ostree#1929 anyway). Haven't gotten around to investigating deeper yet.
Hmm, yeah we've hit that in rpm-ostree CI too. |
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 17, 2019
There's a new update fixing the `statx` failures: https://bodhi.fedoraproject.org/updates/FEDORA-2019-566ad52d5e I strongly suspect this is also the root cause behind the recent CI failures: coreos/fedora-coreos-config#201 (comment) coreos/rpm-ostree#1929 (comment) Let's just pull it in right now so we can get things unblocked.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 17, 2019
There's a new update awaiting karma that fixes the `statx` failures: https://bodhi.fedoraproject.org/updates/FEDORA-2019-566ad52d5e I strongly suspect this is also the root cause behind the recent CI failures: coreos/fedora-coreos-config#201 (comment) coreos/rpm-ostree#1929 (comment) Let's just pull it in right now so we can get things unblocked.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 17, 2019
There's a new update awaiting karma that fixes the `statx` failures: https://bodhi.fedoraproject.org/updates/FEDORA-2019-566ad52d5e I strongly suspect this is also the root cause behind the recent CI failures: coreos/fedora-coreos-config#201 (comment) coreos/rpm-ostree#1929 (comment) Let's just pull it in right now so we can get things unblocked.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 17, 2019
There's a new update awaiting karma that fixes the `statx` failures: https://bodhi.fedoraproject.org/updates/FEDORA-2019-566ad52d5e I strongly suspect this is also the root cause behind the recent CI failures: coreos/fedora-coreos-config#201 (comment) coreos/rpm-ostree#1929 (comment) Let's just pull it in right now so we can get things unblocked.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 17, 2019
There's a new update awaiting karma that fixes the `statx` failures: https://bodhi.fedoraproject.org/updates/FEDORA-2019-566ad52d5e I strongly suspect this is also the root cause behind the recent CI failures: coreos/fedora-coreos-config#201 (comment) coreos/rpm-ostree#1929 (comment) Let's just pull it in right now so we can get things unblocked.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 17, 2019
There's a new update awaiting karma that fixes the `statx` failures: https://bodhi.fedoraproject.org/updates/FEDORA-2019-566ad52d5e I strongly suspect this is also the root cause behind the recent CI failures: coreos/fedora-coreos-config#201 (comment) coreos/rpm-ostree#1929 (comment) Let's just pull it in right now so we can get things unblocked.
|
Deprecation warnings addressed in rpm-software-management/libdnf#819! |
jlebon
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Oct 17, 2019
There's a new update awaiting karma that fixes the `statx` failures: https://bodhi.fedoraproject.org/updates/FEDORA-2019-566ad52d5e I strongly suspect this is also the root cause behind the recent CI failures: coreos/fedora-coreos-config#201 (comment) coreos/rpm-ostree#1929 (comment) Let's just pull it in right now so we can get things unblocked.
|
are we able to retrigger CI yet? anyone opposed to merging this? |
|
The container is still rebuilding. Do you have the final diff for this? (Or CI will give it to us once it's back up. Edit: ahh right, this needs #176) |
|
The final diff is: |
|
This makes sense, though I'd also like to land too |
dustymabe
pushed a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: coreos/fedora-coreos-tracker#38