Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make handling of boot= and root= kargs idempotent #2141

Closed
wants to merge 4 commits into from
Closed

Make handling of boot= and root= kargs idempotent #2141

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f7197a
dracut/boot-edit: Do nothing if we have a boot= karg
cgwalters Jan 2, 2023
df01601
dracut/ignition-setup: Use boot= karg if it exists
cgwalters Jan 2, 2023
7b4d459
ignition-uuid-root: no-op if we already have a root= karg
cgwalters Jan 10, 2023
d01094a
overlay: More no-ops if we have a boot= and/or root= karg
cgwalters Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...lay.d/05core/usr/lib/dracut/modules.d/40ignition-ostree/ignition-ostree-uuid-root.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ After=ignition-disks.service
# If we've reprovisioned the rootfs, then there's no need to restamp
ConditionPathExists=!/run/ignition-ostree-transposefs
ConditionKernelCommandLine=!rootfs.roothash
ConditionKernelCommandLine=!root
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would break multipath, where currently you have to put the root karg at install time but we do still want the restamping. Is this actually required for bootc? The service will run but the script should no-op if the filesystem UUID was already randomized.

Similarly for coreos-gpt-setup.service.


After=dev-disk-by\x2dlabel-root.device
# Avoid racing with fsck
Expand Down