Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denylist: bump snooze for kdump.crash and drop extensions.module #2284

Merged
merged 2 commits into from
Mar 8, 2023
Merged

denylist: bump snooze for kdump.crash and drop extensions.module #2284

merged 2 commits into from
Mar 8, 2023

Conversation

gursewak1997
Copy link
Member

@gursewak1997 gursewak1997 commented Mar 8, 2023

We are still waiting on updates for #1430 so bumping the snooze for kdump.crash for now. Also dropping ext.config.extensions.module` from denylist as the test passes in rawhide now.
Closes: coreos/fedora-coreos-tracker#1420

@@ -46,7 +46,7 @@
snooze: 2023-03-10
- pattern: ext.config.extensions.module
tracker: https://github.com/coreos/fedora-coreos-tracker/issues/1420
snooze: 2023-03-08
snooze: 2023-03-22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did ext.config.extensions.module fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it did not yet. I bumped the snooze seeing the issue is still open.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue just needs an update. The snooze is the mechanism by which it gets updated. If the test is passing now then the issue can be updated and closed and this snooze dropped.

@@ -58,7 +58,7 @@
- next
- pattern: ext.config.kdump.crash
tracker: https://github.com/coreos/fedora-coreos-tracker/issues/1430
snooze: 2023-03-08
snooze: 2023-03-22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did ext.config.kdump.crash fail?
did it fail on more than one stream?

If it failed on next-devel let's add next to the list of streams below since we'll be releasing f38 content on next soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it failed on next-devel, so will add next to it.

@gursewak1997 gursewak1997 changed the title denylist: bump snooze for kdump.crash and extensions.module denylist: bump snooze for kdump.crash and drop extensions.module Mar 8, 2023
@dustymabe
Copy link
Member

Usually what I would do here is update coreos/fedora-coreos-tracker#1420 with the new information, then add a commit here dropping the snooze and linking to that and ultimately closing the issue when it merges.

Bumping the snooze for the separate test would be in a different (2nd) commit (with a different rationale in the commit message).

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) March 8, 2023 18:32
@dustymabe dustymabe merged commit 423235a into coreos:testing-devel Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rawhide]: ext.config.extensions.module failing due to missing modular package
2 participants