Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] overlay/15fcos: upgrade bootloader on aarch64 at boot #2307

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[next] overlay/15fcos: upgrade bootloader on aarch64 at boot #2307

merged 1 commit into from
Mar 20, 2023

Conversation

bgilbert
Copy link
Contributor

On aarch64, kernel 6.2 won't boot with older versions of GRUB. In preparation for switching to the new kernel, add a systemd service that uses bootupd to update the bootloader on aarch64 systems.

Revert this after the next barrier release.

For coreos/fedora-coreos-tracker#1441. Not heavily tested.

@bgilbert bgilbert changed the title overlay/15fcos: upgrade bootloader on aarch64 at boot [next] overlay/15fcos: upgrade bootloader on aarch64 at boot Mar 17, 2023
On aarch64, kernel 6.2 won't boot with older versions of GRUB.  In
preparation for switching to the new kernel, add a systemd service that
uses bootupd to update the bootloader on aarch64 systems.

Revert this after the next barrier release.

For coreos/fedora-coreos-tracker#1441.
@bgilbert
Copy link
Contributor Author

Downgrade detector detected downgrades.

@dustymabe
Copy link
Member

This seems to be working in a preliminary test for me. Want to open a similar PR up against testing-devel since we'll need this in the other streams too?

I'll try to do some more testing tomorrow.

@bgilbert
Copy link
Contributor Author

testing-devel in #2308.

@dustymabe
Copy link
Member

I tested this with a new upgrade script I wrote.. Here is some selected output:

[builder@coreos-aarch64-builder fcos]$ tail -f  tmp/kola/ext.config.upgrade/*/journal.txt | grep --color -i 'ok reached version'                                                   
Mar 20 02:25:12.584096 kola-runext-test.sh[2085]: ok Reached version: 34.20210904.1.0                                                                                              
Mar 20 02:26:37.107738 kola-runext-test.sh[3538]: ok Reached version: 35.20210924.1.0                                                                                              
Mar 20 02:28:08.509482 kola-runext-test.sh[1668]: ok Reached version: 36.20220418.1.0                                                                                              
Mar 20 02:28:41.242555 kola-runext-test.sh[1649]: ok Reached version: 36.20220906.1.0                                                                                                                                                                                                                                                                     
Mar 20 02:29:33.635979 kola-runext-test.sh[1635]: ok Reached version: 37.20221111.1.0                                                                                              
Mar 20 02:30:16.657854 kola-runext-test.sh[1469]: ok Reached version: 37.20230303.1.0                                                                                              
Mar 20 02:31:17.440458 kola-runext-test.sh[1297]: ok Reached version: 37.20230320.dev.0                                                                                            
Mar 20 02:32:14.601624 kola-runext-test.sh[1264]: ok Reached version: 38.20230310.1.0

The 37.20230320.dev.0 is a local build that includes this PR.

The bootupctl update looks like:

Mar 20 02:31:04.636253 systemd[1]: Starting coreos-bootupctl-update-aarch64.service - Update aarch64 Bootloader...
Mar 20 02:31:05.087429 bootupctl[740]: Updated EFI: grub2-efi-aa64-1:2.06-88.fc37.aarch64,shim-aa64-15.6-2.aarch64
Mar 20 02:31:05.088124 systemd[1]: Finished coreos-bootupctl-update-aarch64.service - Update aarch64 Bootloader.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple!

@@ -0,0 +1,15 @@
# Remove after the next barrier release
# https://github.com/coreos/fedora-coreos-tracker/issues/1441
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: could make this a Documentation key.

@dustymabe dustymabe marked this pull request as ready for review March 20, 2023 18:31
@dustymabe dustymabe merged commit b9f8903 into coreos:next Mar 20, 2023
@jlebon
Copy link
Member

jlebon commented Mar 20, 2023

Also tested this manually locally with success starting from the very first aarch64 next image. Rebooting into f38 after the bootloader autoupdate worked.

@bgilbert bgilbert deleted the bootloader/next branch March 20, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants