Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for tests #2397

Merged
merged 6 commits into from
May 8, 2023
Merged

Conversation

HuijingHei
Copy link
Member

@HuijingHei HuijingHei force-pushed the test-description branch 6 times, most recently from 7a6921d to 2c66e7c Compare April 26, 2023 15:53
cgwalters
cgwalters previously approved these changes Apr 26, 2023
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HuijingHei HuijingHei force-pushed the test-description branch 2 times, most recently from 03ba5d8 to 7bf1fec Compare April 27, 2023 02:35
@HuijingHei HuijingHei marked this pull request as ready for review April 27, 2023 02:36
tests/kola/ignition/kargs/test.sh Outdated Show resolved Hide resolved
tests/kola/ignition/delete-config/test.sh Outdated Show resolved Hide resolved
tests/kola/ignition/kargs/test.sh Outdated Show resolved Hide resolved
@HuijingHei HuijingHei force-pushed the test-description branch 4 times, most recently from 39f27c8 to 857995f Compare May 4, 2023 06:47
Copy link
Member

@mike-nguyen mike-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I noticed that sometimes description: > was used on multi-line descriptions. Should we use that for all multi-line descriptions or not? For non-external tests (tests in coreos-assembler mantle kola) the concept of > doesn't exist.

The resulting json output from using > results in a newline character before the description text. Example below:

[
  "ext.config.files.check-symlink",
  "Verify /etc release symlinks are valid.\nSee\n- https://bugzilla.redhat.com/show_bug.cgi?id=2068148\n- https://github.com/openshift/os/pull/815"
]
[
  "ext.config.files.console-config",
  "\nVerify that the kargs and grub.cfg commands specified in \nplatforms.json have been properly applied to the image. \nAlso check cosa correctly translated platforms.yaml to  \nplatforms.json, by spot-checking certain expected values\nin platforms.json.\n"
]

I don't know if that will ultimately make any difference when we try to import into Polarion.

tests/kola/boot/bootupd Outdated Show resolved Hide resolved
@HuijingHei
Copy link
Member Author

I don't know if that will ultimately make any difference when we try to import into Polarion.

Agree that it looks ugly for human reading as many \n.
It will look normal if using =SUBSTITUTE(<E2>,"\n",CHAR(10)) to convert \n to real new line in google sheet before importing into Polarion.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great!

tests/kola/boot/grub2-install Outdated Show resolved Hide resolved
tests/kola/files/aleph-version Outdated Show resolved Hide resolved
tests/kola/ignition/journald-log Outdated Show resolved Hide resolved
tests/kola/networking/hostname/fallback-hostname/test.sh Outdated Show resolved Hide resolved
tests/kola/networking/nameserver Outdated Show resolved Hide resolved
tests/kola/networking/nic-naming Outdated Show resolved Hide resolved
tests/kola/networking/rd-net-timeout-carrier/test.sh Outdated Show resolved Hide resolved
tests/kola/toolbox/test.sh Outdated Show resolved Hide resolved
tests/kola/boot/grub2-install Outdated Show resolved Hide resolved
tests/kola/firewall/iptables/test.sh Outdated Show resolved Hide resolved
tests/kola/platforms/aws/assert-xen Outdated Show resolved Hide resolved
tests/kola/rpm-ostree/kernel-replace Outdated Show resolved Hide resolved
@HuijingHei
Copy link
Member Author

HuijingHei commented May 6, 2023

I noticed that sometimes description: > was used on multi-line descriptions. Should we use that for all multi-line descriptions or not? For non-external tests (tests in coreos-assembler mantle kola) the concept of > doesn't exist.

SGTM. I will try to drop description: >. Thanks for the suggestion.

- Remove `description: >`
- Replace related links into comments
@HuijingHei
Copy link
Member Author

Done for the updates, thanks all for the review and suggestions.

@mike-nguyen
Copy link
Member

LGTM

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't re-review the full diff in detail, but the interdiff looks good. Nice work @HuijingHei!

@jlebon jlebon merged commit 91258f4 into coreos:testing-devel May 8, 2023
@HuijingHei HuijingHei deleted the test-description branch July 4, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants